Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: clean up tox environments & CI gates #2353

Merged
merged 9 commits into from
Oct 4, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Oct 4, 2024

I will change the branch protection rules later if we are OK to proceed with this PR.
That is actually one of the major reasons behind this change, I don't want to keep rewriting all the rules every time we change the default Python version.

Copy link

codecov bot commented Oct 4, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (46b7fdd) to head (c0927cd).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2353   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           64        64           
  Lines         7624      7624           
  Branches      1246      1246           
=========================================
  Hits          7624      7624           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vytas7 vytas7 requested review from CaselIT and kgriffs October 4, 2024 15:14
@vytas7 vytas7 marked this pull request as ready for review October 4, 2024 15:14
Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left some minor comments, mainly about versions

.github/workflows/test-other.yaml Show resolved Hide resolved
.github/workflows/tests.yaml Show resolved Hide resolved
tox.ini Show resolved Hide resolved
@vytas7 vytas7 merged commit 67c4501 into falconry:master Oct 4, 2024
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants