-
-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Response): support Partitioned cookie attribute #2248
Conversation
Allow to set the Partitioned attribute in cookies. Default is not setting it. closes falconry#2213
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2248 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 6847 6852 +5
Branches 1258 1260 +2
=========================================
+ Hits 6847 6852 +5 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
great work, thanks!
regarding the too-complex error I think we can suppress it adding falcon/falcon/routing/compiled.py Line 150 in 09189a8
|
ok you already did that, great! |
The MDN documentation is a lot more helpful than the draft and also links to the draft specification
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks!
Co-authored-by: Federico Caselli <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, LGTM! 💯
*Bar some small docs tweaks that I would like to make, but I don't think we need to delay this PR just because of that (I can address that off-band in a followup PR.)
Summary of Changes
Allow to set the Partitioned attribute in cookies. Default is not setting it.
The changes are very similar to the changes required for the SameSite attribute.
Related Issues
fixes: #2213
Pull Request Checklist
This is just a reminder about the most common mistakes. Please make sure that you tick all appropriate boxes. But please read our contribution guide at least once; it will save you a few review cycles!
If an item doesn't apply to your pull request, check it anyway to make it apparent that there's nothing to do.
docs/
.docs/
.versionadded
,versionchanged
, ordeprecated
directives.docs/_newsfragments/
, with the file name format{issue_number}.{fragment_type}.rst
. (Runtowncrier --draft
to ensure it renders correctly.)If you have any questions to any of the points above, just submit and ask! This checklist is here to help you, not to deter you from contributing!
PR template inspired by the attrs project.