-
-
Notifications
You must be signed in to change notification settings - Fork 946
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: change setup.py
to use optional build_ext option
#2242
Conversation
This allows skipping the compilation of the c file if it fails for some reason, like the compiler is missing. The build will still fail if cython can't generate the c file from the py/pyx file but that should be ok.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2242 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 6852 6852
Branches 1260 1260
=========================================
Hits 6852 6852 ☔ View full report in Codecov by Sentry. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, and I've tested it to work well in different scenarios.
But apparently it is conflicted against master
, we need to address these conflicts before merging.
Thanks. Will merge with master soon! |
# Conflicts: # setup.py
updated |
setup.py
to use optional build_ext option
This allows skipping the compilation of the c file if it fails for some reason, like the compiler is missing.
The build will still fail if cython can't generate the c file from the py/pyx file but that should be ok.
The optional keyword is documented here https://setuptools.pypa.io/en/latest/userguide/ext_modules.html#setuptools.Extension
Fixes: #2237