-
-
Notifications
You must be signed in to change notification settings - Fork 948
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: replace flake8
plugins with ruff
#2236
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2236 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 6889 6847 -42
Branches 1258 1258
=========================================
- Hits 6889 6847 -42 ☔ View full report in Codecov by Sentry. |
Looks great 💯 Are you sure we are checking the import order though? I remember playing with that, and even when I configured |
Honestly no, not sure if it activated thwt check |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is shaping up for merging, we just need to revise these tutorial snippets.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 💯
(Even if I missed anything, it should be mostly stylistic.)
Here it goes then |
Replace flake8 with ruff
Not 100% sure all the options are the same, but no major changes were required
Fixes #2231