Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: replace flake8 plugins with ruff #2236

Merged
merged 9 commits into from
Jul 13, 2024
Merged

refactor: replace flake8 plugins with ruff #2236

merged 9 commits into from
Jul 13, 2024

Conversation

CaselIT
Copy link
Member

@CaselIT CaselIT commented Jul 11, 2024

Replace flake8 with ruff

Not 100% sure all the options are the same, but no major changes were required

Fixes #2231

Copy link

codecov bot commented Jul 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (c345420) to head (f810b10).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2236   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6889      6847   -42     
  Branches      1258      1258           
=========================================
- Hits          6889      6847   -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@vytas7 vytas7 changed the title Flake8 to ruff refactor: replace flake8 plugins with ruff Jul 11, 2024
@vytas7
Copy link
Member

vytas7 commented Jul 11, 2024

Looks great 💯

Are you sure we are checking the import order though? I remember playing with that, and even when I configured ruff to follow the Google style we are currently using, it still generated a fair diff, and here I see no changes in that 🤔

@CaselIT
Copy link
Member Author

CaselIT commented Jul 11, 2024

Honestly no, not sure if it activated thwt check

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is shaping up for merging, we just need to revise these tutorial snippets.

examples/asgilook/asgilook/store.py Show resolved Hide resolved
examples/look/look/app.py Show resolved Hide resolved
Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 💯
(Even if I missed anything, it should be mostly stylistic.)

@CaselIT
Copy link
Member Author

CaselIT commented Jul 13, 2024

Here it goes then

@CaselIT CaselIT merged commit 09189a8 into master Jul 13, 2024
72 checks passed
@CaselIT CaselIT deleted the flake8_to_ruff branch July 14, 2024 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Use ruff linter instead of flake8
2 participants