Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(typing): add more descriptive typing to Context #2226

Merged
merged 2 commits into from
Apr 5, 2024

Conversation

vytas7
Copy link
Member

@vytas7 vytas7 commented Apr 5, 2024

This change affords arbitrary attribute access for req.context & resp.context in typed code without having to mask Mypy warnings similar to error: "Context" has no attribute "...".

Copy link

codecov bot commented Apr 5, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (7ec1d31) to head (4c4709f).

Additional details and impacted files
@@            Coverage Diff            @@
##            master     #2226   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           63        63           
  Lines         6930      6931    +1     
  Branches      1109      1109           
=========================================
+ Hits          6930      6931    +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

left a suggestion to dry the code

falcon/util/structures.py Show resolved Hide resolved
@vytas7 vytas7 requested review from nZac, kgriffs and CaselIT April 5, 2024 17:03
Copy link
Member

@CaselIT CaselIT left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯

@vytas7 vytas7 merged commit 64af3cf into falconry:master Apr 5, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants