Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(testing): allow test to be run using pytest-xdist #2172

Merged
merged 2 commits into from
Oct 14, 2023

Conversation

CaselIT
Copy link
Member

@CaselIT CaselIT commented Sep 9, 2023

Trying to run pytest .\tests\ -n 6 --dist=worksteal on master it results in an error since different test are collected.
This is mostly because we parametrize the test on random uuid, that result in the test signature to be different.

This fixes that by creating a deterministic id for the parametrized test where needed

@CaselIT CaselIT requested a review from vytas7 September 9, 2023 20:58
@codecov
Copy link

codecov bot commented Sep 9, 2023

Codecov Report

Merging #2172 (311a4be) into master (32207fe) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##            master     #2172   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           62        62           
  Lines         6869      6869           
  Branches      1098      1098           
=========================================
  Hits          6869      6869           

tests/_util.py Show resolved Hide resolved
@vytas7 vytas7 changed the title Allow test to be run using pytest-xdist chore(testing): allow test to be run using pytest-xdist Sep 10, 2023
vytas7
vytas7 previously approved these changes Oct 14, 2023
@CaselIT
Copy link
Member Author

CaselIT commented Oct 14, 2023

Added a note there, can you take a second look?

Copy link
Member

@vytas7 vytas7 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vytas7 vytas7 merged commit 18934a1 into falconry:master Oct 14, 2023
35 checks passed
@CaselIT CaselIT deleted the allow_pytest_to_run_with_xdist branch August 21, 2024 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants