feat(typing): add type hints to compiled router #1944
Merged
+159
−97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this is mainly to try how cython works with pep484 types
CaselIT
force-pushed
the
type_compiled_wip
branch
from
7c14345 to
8e4adf1
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1944 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 63 63
Lines 6847 6847
Branches 1258 1258
=========================================
Hits 6847 6847 ☔ View full report in Codecov by Sentry. |
vytas7
reviewed
Oct 16, 2021
|
This should be good to revisit again once #1947 gets merged. |
vytas7
changed the title
|
@CaselIT Now we can continue with this one; we just need to address merge conflicts and it may possible to move this forward off Draft. |
|
I'll try getting into it soonish |
# Conflicts: # falcon/routing/compiled.py
vytas7
approved these changes
Jul 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is mainly to try how cython works with pep484 types
NOTE: this is currently unmergiable, since it's not py 3.5 compatible
Gist with the compilations with cython https://gist.github.com/CaselIT/f0493d74422cce46c95c10e8abd1e4f0