-
-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add MessagePack support to the test client #1026
Comments
@vytas7 I Would like to contribute , can you explain a bit the problem ? |
Hi @hk-madhu! I assume this issue aims to deliver that same functionality for testing APIs that leverage Msgpack instead of (or in addition to) JSON. |
Hi, after checking some issues, I would like to take this one, is there somebody contributing? |
I don't think so. Feel free to work on it! |
Ok, is there any extra information I need to know to start working on it? |
I don't think so. Feel free to ask if you have questions |
How do I start tackling this problem? Should I do it on tox setup? Sorry if the questions seem simple, but this is my first time contributing on an open source project. |
Hi @arthurprioli, no worries, these are valid questions! For development of the framework itself, it is probably easiest to use an "editable" install so that you can run isolated tests even outside of $ FALCON_DISABLE_CYTHON=Y pip install -e . Then, when you are comfortable with the very basics, check our contributor's guide: Contribute to Falcon. Let us know if you have any other further questions! |
Hey guys, sorry I took long to answer, we had a small holiday here in Brazil and I had a small travel. I'm currently finishing the get started tutorial on Falcon's official documentation, so I made some tests with pytest. I also read on how to contribute to Falcon. My question is: how should I start this issue? In order to add MessagePack support to the TestClient? |
Hello guys, I took a bigger look on the source code and searched the web a bit about how to add dependencies as extra. Also read #333. What is setuptools? And what files should I take a look in order to add msgpack-python as an extra dependencie? |
Hi again @arthurprioli, no, we don't want to add any hard dependencies on any 3rd party libraries. |
Hello @vytas7, just took a look at it and also read how |
Hi @arthurprioli, it is okay that you share information and ask questions, but please don't send text blocks as images, that's something I really don't like 👿 As to your issues, so
Maybe you could join us on Gitter ( |
Note: When doing this,
msgpack-python
must be added as an extra dependency (see also #333) so that those who don't want to bring it in are not forced to do so.The text was updated successfully, but these errors were encountered: