Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added elevator subsystem. #9

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Added elevator subsystem. #9

wants to merge 1 commit into from

Conversation

Matero952
Copy link

@Matero952 Matero952 commented Jan 10, 2025 •
edited by aaditsangvikar
Loading

close: #6

TotalTaxAmount
TotalTaxAmount requested changes Jan 10, 2025
View reviewed changes
Copy link
Member

@TotalTaxAmount TotalTaxAmount left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, maybe add some javadoc to your functions like:

/**
* Intelij will give you some suggestions
* ...
*/
public void myFunction() {}

TotalTaxAmount
TotalTaxAmount reviewed Jan 10, 2025
View reviewed changes
src/main/java/frc/robot/subsystems/ElevatorSubsystem.java
rightElevatorMotor.configure(rightElevatorMotorConfig, SparkBase.ResetMode.kNoResetSafeParameters, SparkBase.PersistMode.kPersistParameters);
leftElevatorMotor.configure(leftElevatorMotorConfig, SparkBase.ResetMode.kResetSafeParameters, SparkBase.PersistMode.kPersistParameters);
}
public void moveElevator(double speed) {
Copy link
Member

@TotalTaxAmount TotalTaxAmount Jan 10, 2025 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe make this private and give it a name like setElevatorPercent or setElevatorSpeed

TotalTaxAmount
TotalTaxAmount reviewed Jan 10, 2025
View reviewed changes
src/main/java/frc/robot/subsystems/ElevatorSubsystem.java
}
//TODO We need to LEFT_ELEVATOR_ID do something for L1, L2, L3
//NO absolute encoders
public void setVoltage(double voltage) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also private probably

@Matero952
Copy link
Author

Thank you, I will make the changes now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TotalTaxAmount TotalTaxAmount TotalTaxAmount requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Elevator Base Code
2 participants
@Matero952 @TotalTaxAmount