Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename HookConfiguration to CaptainHook::Configuration #9

Merged
merged 1 commit into from
Nov 8, 2024

Conversation

atd
Copy link
Contributor

@atd atd commented Nov 7, 2024

Follow the standard ruby gem folder structure with a gem_name.rb and a gem_name folder with the rest of the library

This makes it predictable for external developers and it will prevent from polluting the global namespace with classes from the gem

Follow the starndard ruby gem folder structure with a gem_name.rb
and a gem_name folder with the rest of the library

This makes it predictable for external developers and it will prevent
from polluting the global namespace with classes from the gem
Copy link
Member

@gtrias gtrias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great! makes sense 🚀

@atd atd merged commit 047cd32 into main Nov 8, 2024
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants