Use prepend instead of alias_method_chain like approach #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Current implementation is using an old approach of renaming decorated methods. This approach has some drawback, like the inhability to call super, confusing method names, and other issues explanined here by Justin Weiss https://www.justinweiss.com/articles/rails-5-module-number-prepend-and-the-end-of-alias-method-chain/ The solution was proposed in Rails 5: using Ruby's prepend module to define the methods that need to be decorated. This commit creates a new `ClassName::CaptainHookDecorator` module in each class where `hook` is called, prepends it to the class, and defines the relevant decorator methods in that module
gtrias
approved these changes
Nov 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The current implementation is using an old approach of renaming decorated methods. This approach has some drawbacks, like the inability to call
super, confusing method names, and other issues explained here by Justin Weisshttps://www.justinweiss.com/articles/rails-5-module-number-prepend-and-the-end-of-alias-method-chain/
An alternative was proposed in Rails 5: using Ruby's
prependmodule to define the methods that need to be decorated.This commit creates a new
ClassName::CaptainHookDecoratormodule in each class wherehookis called, prepends it to the class, and defines the relevant decorator methods in that module