fixed recursivity problem

factorialco · Oct 21, 2024 · 838c635 · 838c635
1 parent 3a3f7d4
commit 838c635
Show file tree

Hide file tree

Showing 2 changed files with 5 additions and 3 deletions.
diff --git a/lib/captain_hook.rb b/lib/captain_hook.rb
@@ -163,7 +163,9 @@ def decorate_method!(method_name)
 
       original_method_name = :"#{method_name}__without_hooks"
 
-      alias_method original_method_name, method_name unless method_defined?(original_method_name)
+      return if method_defined?(original_method_name)
+
+      alias_method original_method_name, method_name
 
       # We decorate the method with the before, after and around hooks
       define_method(method_name) do |*args, **kwargs|

diff --git a/spec/captain_hook_spec.rb b/spec/captain_hook_spec.rb
@@ -95,7 +95,7 @@ def foo(dto:); end
 
   def prepare(dto:)
     super(dto: dto)
-    "servig food"
+    "child #{dto}"
   end
 end
 
@@ -153,7 +153,7 @@ def prepare(dto:)
       subject.foo(dto: "fooing")
 
       expect_any_instance_of(BeforeAllHook).to receive(:call).once
-      subject.prepare(dto: "foo")
+      expect(subject.prepare(dto: "foo")).to eq("child foo")
     end
   end
 end