Individual pixel gain in spe #204
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
January 20, 2017 11:23
the template pulse integral between the "half height" and "half height + 30 slices" I have calculated with python to be 24.37 but it cannot stay like this!
dneise
commented
Jan 20, 2017
| @@ -148,6 +170,42 @@ private void addStartSliceOffset(int[][] arr) { | |||
| } | |||
| } | |||
|
|
|||
| public double[] loadIntegralGainFile(SourceURL inputUrl, Logger log) { | |||
| factSinglePePulseIntegral = TemplatePulse.factSinglePePulseIntegral(); | |||
There was a problem hiding this comment.
this is shit .. I am misusing loadIntegralGainFile as an __init__ method. so I initialize this member here...
but that's of course total bullshit.
… gains. This is done, because there are two processors (BasicExtraction and SinglePulseExtraction) needing this gain calibration.
|
We should not merge this, if we think #207 is good, which I do. |
|
Yep, let's wait for #207 |
added 3 commits
January 24, 2017 09:52
from mV to SinglePulseAmplitude; This should be used before BasicExtraction or any extration happens.
BasicExtraction became a StatefulProcessor now: - to calculate the template integral ParameterTest uses SinglePulseGaincalibration before extraction starts.
added 15 commits
January 25, 2017 17:32
I've got no idea |
|
What we call Integral Gain in FACT-Tools is around 240, what is here called Single Pulse Integral gain seems to be around 1.0, so how come from one to the other? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixing #197