Add profiling for countDocuments() and estimatedDocumentCount() #191
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jean85
approved these changes
Nov 5, 2024
phleauran
force-pushed
the
add-count-profiling
branch
from
66c9df2 to
b52c373
Compare
|
Hello. What's next for this PR? |
ilario-pierbattista
approved these changes
Dec 7, 2024
|
Thank you @phleauran, just had some time today to review and merge. I'll release it soon |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The profiling was already set for
count(), but this method is deprecated since 1.4 and has been replaced bycountDocuments().As GromNaN mentioned here, we could get rid of encapsulation by using MongoDB built-in monitoring features, but it would require to refactor a large part of the bundle, so I went for the simple solution.