Fix PHPStan consequent issues

facile-it · Mar 18, 2024 · e676fbe · e676fbe
1 parent 9aa4ca8
commit e676fbe
Show file tree

Hide file tree

Showing 3 changed files with 1 addition and 29 deletions.
diff --git a/phpstan-baseline.neon b/phpstan-baseline.neon
@@ -1,15 +1,5 @@
 parameters:
 	ignoreErrors:
-		-
-			message: "#^Property Facile\\\\MongoDbBundle\\\\Controller\\\\ProfilerController\\:\\:\\$container \\(Symfony\\\\Component\\\\DependencyInjection\\\\Container\\) does not accept Symfony\\\\Component\\\\DependencyInjection\\\\ContainerInterface\\|null\\.$#"
-			count: 1
-			path: src/Controller/ProfilerController.php
-
-		-
-			message: "#^Method Facile\\\\MongoDbBundle\\\\DataCollector\\\\MongoQuerySerializer\\:\\:prepareUnserializableData\\(\\) never returns object so it can be removed from the return type\\.$#"
-			count: 1
-			path: src/DataCollector/MongoQuerySerializer.php
-
 		-
 			message: "#^Call to an undefined method Symfony\\\\Component\\\\Config\\\\Definition\\\\Builder\\\\NodeDefinition\\:\\:children\\(\\)\\.$#"
 			count: 7
@@ -50,31 +40,16 @@ parameters:
 			count: 1
 			path: src/Twig/FacileMongoDbBundleExtension.php
 
-		-
-			message: "#^Method Facile\\\\MongoDbBundle\\\\Tests\\\\Fixtures\\\\DataFixtures\\\\TestFixtures\\:\\:loadData\\(\\) should return array but return statement is missing\\.$#"
-			count: 1
-			path: tests/Fixtures/DataFixtures/TestFixtures.php
-
 		-
 			message: "#^Method Facile\\\\MongoDbBundle\\\\Tests\\\\Fixtures\\\\DataFixtures\\\\TestFixtures\\:\\:loadIndexes\\(\\) should return array but return statement is missing\\.$#"
 			count: 1
 			path: tests/Fixtures/DataFixtures/TestFixtures.php
 
-		-
-			message: "#^Method Facile\\\\MongoDbBundle\\\\Tests\\\\Fixtures\\\\DataFixtures\\\\TestOrderedMongoFixtures2\\:\\:loadData\\(\\) should return array but return statement is missing\\.$#"
-			count: 1
-			path: tests/Fixtures/DataFixtures/TestOrderedMongoFixtures2.php
-
 		-
 			message: "#^Method Facile\\\\MongoDbBundle\\\\Tests\\\\Fixtures\\\\DataFixtures\\\\TestOrderedMongoFixtures2\\:\\:loadIndexes\\(\\) should return array but return statement is missing\\.$#"
 			count: 1
 			path: tests/Fixtures/DataFixtures/TestOrderedMongoFixtures2.php
 
-		-
-			message: "#^Property Facile\\\\MongoDbBundle\\\\Tests\\\\Functional\\\\AppTestCase\\:\\:\\$application \\(Symfony\\\\Bundle\\\\FrameworkBundle\\\\Console\\\\Application\\) does not accept null\\.$#"
-			count: 1
-			path: tests/Functional/AppTestCase.php
-
 		-
 			message: "#^Access to an undefined property MongoDB\\\\Model\\\\BSONDocument\\:\\:\\$fqcn\\.$#"
 			count: 1

diff --git a/src/DataCollector/MongoQuerySerializer.php b/src/DataCollector/MongoQuerySerializer.php
@@ -22,7 +22,7 @@ public static function serialize(Query $query): void
     /**
      * @param array|object $data
      *
-     * @return array|object
+     * @return mixed[]
      */
     private static function prepareUnserializableData($data): array
     {

diff --git a/src/Fixtures/MongoFixturesLoader.php b/src/Fixtures/MongoFixturesLoader.php
@@ -74,9 +74,6 @@ function ($classList, string $className) use ($includedFiles) {
         );
     }
 
-    /**
-     * @param mixed $instance
-     */
     private function buildFixture(object $instance): MongoFixtureInterface
     {
         if ($instance instanceof AbstractContainerAwareFixture) {
-Original file line number
+Diff line change
@@ Expand Up @@
             );
         }
-        /**
-         * @param mixed $instance
-         */
         private function buildFixture(object $instance): MongoFixtureInterface
         {
             if ($instance instanceof AbstractContainerAwareFixture) {
@@ Expand Down @@