Fix OSS logging primitives macros #140
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
|
This pull request was exported from Phabricator. Differential Revision: D52315578 |
georges-berenger
force-pushed
the
export-D52315578
branch
from
1d65065 to
ac3533b
Compare
georges-berenger
pushed a commit
to georges-berenger/vrs-1
that referenced
this pull request
Dec 20, 2023
Summary: The logging macros were not quite working as expected, and a little more black magic fu was required to make them compile and work as expected on all platforms. Differential Revision: D52315578
|
This pull request was exported from Phabricator. Differential Revision: D52315578 |
1 similar comment
|
This pull request was exported from Phabricator. Differential Revision: D52315578 |
georges-berenger
force-pushed
the
export-D52315578
branch
from
ac3533b to
8d44c5f
Compare
georges-berenger
pushed a commit
to georges-berenger/vrs-1
that referenced
this pull request
Dec 20, 2023
Summary: The logging macros were not quite working as expected, and a little more black magic fu was required to make them compile and work as expected on all platforms. Differential Revision: D52315578
|
This pull request was exported from Phabricator. Differential Revision: D52315578 |
georges-berenger
force-pushed
the
export-D52315578
branch
from
8d44c5f to
e626975
Compare
georges-berenger
pushed a commit
to georges-berenger/vrs-1
that referenced
this pull request
Dec 20, 2023
Summary: The logging macros were not quite working as expected, and a little more black magic fu was required to make them compile and work as expected on all platforms. Differential Revision: D52315578
|
This pull request was exported from Phabricator. Differential Revision: D52315578 |
georges-berenger
force-pushed
the
export-D52315578
branch
from
e626975 to
4c1b560
Compare
georges-berenger
pushed a commit
to georges-berenger/vrs-1
that referenced
this pull request
Dec 20, 2023
Summary: The logging macros were not quite working as expected, and a little more black magic fu was required to make them compile and work as expected on all platforms. Differential Revision: D52315578
|
This pull request was exported from Phabricator. Differential Revision: D52315578 |
georges-berenger
force-pushed
the
export-D52315578
branch
from
4c1b560 to
650bd41
Compare
georges-berenger
pushed a commit
to georges-berenger/vrs-1
that referenced
this pull request
Dec 20, 2023
Summary: The logging macros were not quite working as expected, and a little more black magic fu was required to make them compile and work as expected on all platforms. Differential Revision: D52315578
|
This pull request was exported from Phabricator. Differential Revision: D52315578 |
Summary: The logging macros were not quite working as expected, and a little more black magic fu was required to make them compile and work as expected on all platforms. Reviewed By: SeaOtocinclus Differential Revision: D52315578
georges-berenger
force-pushed
the
export-D52315578
branch
from
650bd41 to
a18f28e
Compare
|
This pull request was exported from Phabricator. Differential Revision: D52315578 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary: The logging macros were not quite working as expected, and a little more black magic fu was required to make them compile and work as expected on all platforms.
Differential Revision: D52315578