Skip to content

Commit

Permalink
Update packages for jpeg (#170)
Browse files Browse the repository at this point in the history
Summary:
Pull Request resolved: #170

In pull request 154, there was a mixup between mac and ubuntu packages.
The package name for jpeg in Brew is "jpeg", whereas it's "libjpeg-dev" in Ubuntu.

Reviewed By: hanghu

Differential Revision: D68055117

fbshipit-source-id: 5806fb743eb42b83c0512a9655130cd7f3acdd0e
  • Loading branch information
Georges Berenger authored and facebook-github-bot committed Jan 13, 2025
1 parent 8a043e8 commit 6b6ae79
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build-and-test.yml
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ jobs:
sudo apt-get upgrade
sudo apt-get install -o Acquire::Retries=5 \
cmake git ninja-build libgtest-dev libfmt-dev \
libturbojpeg-dev libpng-dev \
libjpeg-dev libturbojpeg-dev libpng-dev \
liblz4-dev libzstd-dev libxxhash-dev \
libboost-system-dev libboost-filesystem-dev libboost-date-time-dev \
qtbase5-dev portaudio19-dev
Expand Down
2 changes: 1 addition & 1 deletion Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ FROM ubuntu:jammy

# Get dependencies
RUN apt-get update && DEBIAN_FRONTEND="noninteractive" TZ="America/New_York" apt-get install -y tzdata
RUN apt-get install -y git cmake ninja-build ccache libgtest-dev libfmt-dev libturbojpeg-dev\
RUN apt-get install -y git cmake ninja-build ccache libgtest-dev libfmt-dev libjpeg-dev libturbojpeg-dev\
libpng-dev liblz4-dev libzstd-dev libxxhash-dev\
libboost-system-dev libboost-filesystem-dev libboost-date-time-dev\
qtbase5-dev portaudio19-dev\
Expand Down
4 changes: 2 additions & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ system.
[Brew’s web site](https://brew.sh/).
- install tools & libraries:
```
brew install cmake git ninja ccache boost fmt libpng jpeg-turbo libjpeg-dev lz4 zstd xxhash glog googletest
brew install cmake git ninja ccache boost fmt libpng jpeg jpeg-turbo lz4 zstd xxhash glog googletest
brew install qt5 portaudio pybind11
brew install node doxygen
```
Expand All @@ -92,7 +92,7 @@ therefore not supported._

- install tools & libraries:
```
sudo apt-get install cmake git ninja-build ccache libgtest-dev libfmt-dev libturbojpeg-dev libpng-dev
sudo apt-get install cmake git ninja-build ccache libgtest-dev libfmt-dev libjpeg-dev libturbojpeg-dev libpng-dev
sudo apt-get install liblz4-dev libzstd-dev libxxhash-dev
sudo apt-get install libboost-system-dev libboost-filesystem-dev libboost-date-time-dev
sudo apt-get install qtbase5-dev portaudio19-dev
Expand Down

0 comments on commit 6b6ae79

Please sign in to comment.