Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding LoopTune #777

Open
wants to merge 1 commit into
base: development
Choose a base branch
from

Conversation

dejangrubisic
Copy link

Adding LoopTune under the example directory.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 10, 2022
@ChrisCummins
Copy link
Contributor

Oh cool! Okay, I think adding it as a submodule makes sense. Only thing I'd like to check is that this won't break the make -C examples test invocation as pytest may pick up the sources in your repo and try running them.

I see the CI is broken (not by you). I'll test locally before giving the green light to merge.

Cheers,
Chris

@ChrisCummins ChrisCummins self-assigned this Dec 10, 2022
@codecov-commenter
Copy link

codecov-commenter commented Dec 10, 2022

Codecov Report

Merging #777 (683d44a) into development (768e4b7) will decrease coverage by 8.39%.
The diff coverage is n/a.

Additional details and impacted files

Impacted file tree graph

@@               Coverage Diff               @@
##           development     #777      +/-   ##
===============================================
- Coverage        89.01%   80.61%   -8.40%     
===============================================
  Files              131      131              
  Lines             8065     8065              
===============================================
- Hits              7179     6502     -677     
- Misses             886     1563     +677     
Impacted Files Coverage Δ
compiler_gym/envs/gcc/service/gcc_service.py 0.00% <0.00%> (-95.98%) ⬇️
compiler_gym/envs/gcc/gcc_rewards.py 31.42% <0.00%> (-68.58%) ⬇️
compiler_gym/envs/gcc/gcc.py 30.50% <0.00%> (-63.00%) ⬇️
compiler_gym/envs/gcc/datasets/csmith.py 48.88% <0.00%> (-43.34%) ⬇️
compiler_gym/envs/gcc/datasets/chstone.py 51.51% <0.00%> (-42.43%) ⬇️
compiler_gym/envs/gcc/datasets/__init__.py 70.58% <0.00%> (-29.42%) ⬇️
compiler_gym/envs/gcc/gcc_env.py 71.01% <0.00%> (-28.99%) ⬇️
compiler_gym/envs/gcc/datasets/anghabench.py 75.00% <0.00%> (-25.00%) ⬇️
compiler_gym/service/service_cache.py 84.21% <0.00%> (-7.90%) ⬇️
compiler_gym/envs/llvm/datasets/cbench.py 74.11% <0.00%> (-6.74%) ⬇️
... and 11 more

@facebook-github-bot
Copy link

Hi @dejangrubisic!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@ChrisCummins
Copy link
Contributor

I've filed #778 for the CI signals. Once I've fixed that I'll ping you to rebase this PR on development.

Other than that, I checked out the loop_tune repo locally and all looks good. One thing you may want to consider is pinning your CompilerGym dependency in requirements.txt, though that isn't merge blocking.

Cheers,
Chris

@facebook-github-bot
Copy link

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants