-
Notifications
You must be signed in to change notification settings - Fork 129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding LoopTune #777
base: development
Are you sure you want to change the base?
Adding LoopTune #777
Conversation
Oh cool! Okay, I think adding it as a submodule makes sense. Only thing I'd like to check is that this won't break the I see the CI is broken (not by you). I'll test locally before giving the green light to merge. Cheers, |
Codecov Report
Additional details and impacted files@@ Coverage Diff @@
## development #777 +/- ##
===============================================
- Coverage 89.01% 80.61% -8.40%
===============================================
Files 131 131
Lines 8065 8065
===============================================
- Hits 7179 6502 -677
- Misses 886 1563 +677
|
Hi @dejangrubisic! Thank you for your pull request. We require contributors to sign our Contributor License Agreement, and yours needs attention. You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted. ProcessIn order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA. Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with If you have received this in error or have any questions, please contact us at [email protected]. Thanks! |
I've filed #778 for the CI signals. Once I've fixed that I'll ping you to rebase this PR on Other than that, I checked out the loop_tune repo locally and all looks good. One thing you may want to consider is pinning your CompilerGym dependency in Cheers, |
Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks! |
Adding LoopTune under the example directory.