Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[gloo] add a github workflow for re-enabling CI #398

Closed
wants to merge 2 commits into from
Closed

[gloo] add a github workflow for re-enabling CI #398

wants to merge 2 commits into from

Conversation

c-p-i-o
Copy link
Contributor

@c-p-i-o c-p-i-o commented Nov 26, 2024

Re-enable CI for gloo.

  1. Disable libuv build in CI for windows as there are linker errors. Will resolve this later.
  2. Remove tls_tcp_test.cc as this file does not exist anymore.
  3. Put back win.cc and win.h files that were erroneously deleted.

@c-p-i-o
[gloo] migrate circleci to github 1/N
8a3d399 
Summary:
Migrate circleci to github actions.
Circleci has been removed from gloo and the goal here is to revive CI
but use github actions instead.

1. Put back win.cc and win.h that were erroneously deleted.
2. Comment out uv build as this breaks CI because of errors for now. I will
address these in a follow-on diff.
3. Add a build.yaml to do a windows build.

Test Plan:
Test on github.

Reviewers:

Subscribers:

Tasks:

Tags:

ghstack-source-id: 447b9a4951a865a2c82abd3ca08f6cea830ac155
Pull Request resolved: #395
@c-p-i-o
[gloo] reenable libuv build (2/N)
f944f46 
Summary:
As part of reviving CI, reenable libuv - but leave it disabled for
MSBUILD - until we can figure out linker errors.

Test Plan:
Test on github.

ghstack-source-id: a69c363f2693e69b7a8dfb14764c0d95736efabc
Pull Request resolved: #396
@c-p-i-o c-p-i-o self-assigned this Nov 26, 2024
@c-p-i-o c-p-i-o requested a review from d4l3k November 26, 2024 23:03
@facebook-github-bot
Copy link

@c-p-i-o has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link

@c-p-i-o merged this pull request in accd654.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@d4l3k d4l3k d4l3k approved these changes

Assignees

@c-p-i-o c-p-i-o

Labels
CLA Signed Merged
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@c-p-i-o @facebook-github-bot @d4l3k