[gloo] migrate circleci to github 1/N #395
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: Migrate circleci to github actions. Circleci has been removed from gloo and the goal here is to revive CI but use github actions instead. 1. Put back win.cc and win.h that were erroneously deleted. 2. Comment out uv build as this breaks CI because of errors for now. I will address these in a follow-on diff. 3. Add a build.yaml to do a windows build. Test Plan: Test on github. Reviewers: Subscribers: Tasks: Tags: [ghstack-poisoned]
c-p-i-o
added a commit
that referenced
this pull request
Nov 18, 2024
Summary: Migrate circleci to github actions. Circleci has been removed from gloo and the goal here is to revive CI but use github actions instead. 1. Put back win.cc and win.h that were erroneously deleted. 2. Comment out uv build as this breaks CI because of errors for now. I will address these in a follow-on diff. 3. Add a build.yaml to do a windows build. Test Plan: Test on github. Reviewers: Subscribers: Tasks: Tags: ghstack-source-id: 447b9a4951a865a2c82abd3ca08f6cea830ac155 Pull Request resolved: #395
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
Summary:
Migrate circleci to github actions.
Circleci has been removed from gloo and the goal here is to revive CI
but use github actions instead.
address these in a follow-on diff.
Test Plan:
Test on github.
Reviewers:
Subscribers:
Tasks:
Tags: