Skip to content

Commit

Permalink
Update on "[gloo] reenable libuv build (2/N)"
Browse files Browse the repository at this point in the history
Summary:
As part of reviving CI, reenable libuv builds - but disable it for the windows build for now until we can figure out linker errors.

Test Plan:
Test on github.

Reviewers:

Subscribers:

Tasks:

Tags:

[ghstack-poisoned]
  • Loading branch information
c-p-i-o committed Nov 26, 2024
1 parent 8d5b86d commit 94b7c1b
Showing 1 changed file with 1 addition and 3 deletions.
4 changes: 1 addition & 3 deletions .github/workflows/build.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,7 +11,6 @@ jobs:
env:
gtest_lib_path: c:/googletest
libuv_path: c:/libuv
CMAKE_ARGS: "-DGLOO_HAVE_TRANSPORT_UV=OFF"
steps:
- uses: conda-incubator/setup-miniconda@v3
with:
Expand Down Expand Up @@ -69,8 +68,7 @@ jobs:
git submodule update --init --recursive
mkdir -p build
cd build
# TODO transport uv is OFF because of linker errors. Figure this out.
cmake .. -DBUILD_TEST=ON -Dlibuv_ROOT=${{ env.libuv_path }} -DGTEST_LIBRARY=${{ env.gtest_lib_path }}/lib/gtestd.lib -DGLOO_HAVE_TRANSPORT_UV=OFF -DGTEST_INCLUDE_DIR=${{ env.gtest_lib_path }}/include -DGTEST_MAIN_LIBRARY=${{ env.gtest_lib_path }}/lib/gtest_maind.lib
cmake .. -DBUILD_TEST=ON -Dlibuv_ROOT=${{ env.libuv_path }} -DGTEST_LIBRARY=${{ env.gtest_lib_path }}/lib/gtestd.lib -DGTEST_INCLUDE_DIR=${{ env.gtest_lib_path }}/include -DGTEST_MAIN_LIBRARY=${{ env.gtest_lib_path }}/lib/gtest_maind.lib
msbuild ALL_BUILD.vcxproj
- name: Test
run: |
Expand Down

0 comments on commit 94b7c1b

Please sign in to comment.