Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Delete default error constructors (#351)
Summary: As they should have been deleted, since `std::runtime_error` does not provide a default constructor. Fixes following compilation warnings: ``` /Users/malfet/git/pytorch/pytorch/third_party/gloo/gloo/common/error.h:25:3: warning: explicitly defaulted default constructor is implicitly deleted [-Wdefaulted-function-deleted] Exception() = default; ^ /Users/malfet/git/pytorch/pytorch/third_party/gloo/gloo/common/error.h:24:20: note: default constructor of 'Exception' is implicitly deleted because base class 'std::runtime_error' has no default constructor struct Exception : public std::runtime_error { ^ /Users/malfet/git/pytorch/pytorch/third_party/gloo/gloo/common/error.h:35:3: warning: explicitly defaulted default constructor is implicitly deleted [-Wdefaulted-function-deleted] InvalidOperationException() = default; ^ /Users/malfet/git/pytorch/pytorch/third_party/gloo/gloo/common/error.h:34:36: note: default constructor of 'InvalidOperationException' is implicitly deleted because base class '::gloo::Exception' has a deleted default constructor struct InvalidOperationException : public ::gloo::Exception { ^ /Users/malfet/git/pytorch/pytorch/third_party/gloo/gloo/common/error.h:25:3: note: explicitly defaulted function was implicitly deleted here Exception() = default; ^ /Users/malfet/git/pytorch/pytorch/third_party/gloo/gloo/common/error.h:24:20: note: default constructor of 'Exception' is implicitly deleted because base class 'std::runtime_error' has no default constructor struct Exception : public std::runtime_error { ^ /Users/malfet/git/pytorch/pytorch/third_party/gloo/gloo/common/error.h:46:3: warning: explicitly defaulted default constructor is implicitly deleted [-Wdefaulted-function-deleted] IoException() = default; ^ /Users/malfet/git/pytorch/pytorch/third_party/gloo/gloo/common/error.h:45:22: note: default constructor of 'IoException' is implicitly deleted because base class '::gloo::Exception' has a deleted default constructor struct IoException : public ::gloo::Exception { ^ /Users/malfet/git/pytorch/pytorch/third_party/gloo/gloo/common/error.h:25:3: note: explicitly defaulted function was implicitly deleted here Exception() = default; ^ /Users/malfet/git/pytorch/pytorch/third_party/gloo/gloo/common/error.h:24:20: note: default constructor of 'Exception' is implicitly deleted because base class 'std::runtime_error' has no default constructor struct Exception : public std::runtime_error { ^ 3 warnings generated. ``` Pull Request resolved: #351 Reviewed By: atalman Differential Revision: D42974916 Pulled By: malfet fbshipit-source-id: e591a4d75fc31e34c61bdadb7067769b42459254
- Loading branch information