Skip to content

Commit

Permalink
Remove unused variables in gloo/transport/ibverbs/device.cc
Browse files Browse the repository at this point in the history
Summary:
LLVM-15 has a warning `-Wunused-but-set-variable` which we treat as an error because it's so often diagnostic of a code issue. Unused variables can compromise readability or, worse, performance.

This diff either (a) removes an unused variable and, possibly, it's associated code, or (b) qualifies the variable with `[[maybe_unused]]`, mostly in cases where the variable _is_ used, but, eg, in an `assert` statement that isn't present in production code.

 - If you approve of this diff, please use the "Accept & Ship" button :-)

Reviewed By: danzimm, meyering

Differential Revision: D52847976

fbshipit-source-id: 6c797d181b3682613c0ab44689461b0515727306
  • Loading branch information
r-barnes authored and facebook-github-bot committed Jan 17, 2024
1 parent 6a4f7ed commit 28d85a4
Showing 1 changed file with 0 additions and 2 deletions.
2 changes: 0 additions & 2 deletions gloo/transport/ibverbs/device.cc
Original file line number Diff line number Diff line change
Expand Up @@ -25,8 +25,6 @@ namespace gloo {
namespace transport {
namespace ibverbs {

static const std::chrono::seconds kTimeoutDefault = std::chrono::seconds(30);

// Scope guard for ibverbs device list.
class IbvDevices {
public:
Expand Down

0 comments on commit 28d85a4

Please sign in to comment.