Skip to content
This repository has been archived by the owner on Feb 2, 2021. It is now read-only.

Commit

Permalink
fixing testTestSpecifierIsAllWhenRunningAllTestsInApplicationTestBundle
Browse files Browse the repository at this point in the history
This test was only passing for me because the build settings file (from
my local machine) happened to refer to a path that existed on my local
machine.

Let's commit the TEST_HOST binary so it can pass on Travis CI, too.
  • Loading branch information
fpotter committed Nov 26, 2013
1 parent 725ded7 commit 720d152
Show file tree
Hide file tree
Showing 5 changed files with 12 additions and 11 deletions.
11 changes: 6 additions & 5 deletions xctool/xctool-tests/OCUnitTestRunnerTests.m
Original file line number Diff line number Diff line change
Expand Up @@ -12,6 +12,7 @@
#import "OCUnitOSXLogicTestRunner.h"
#import "OCUnitIOSAppTestRunner.h"
#import "OCUnitIOSLogicTestRunner.h"
#import "OCUnitTestQueryRunner.h"
#import "ReporterEvents.h"
#import "SimulatorLauncher.h"
#import "Swizzler.h"
Expand Down Expand Up @@ -313,11 +314,11 @@ - (void)testTestSpecifierIsSelfWhenRunningAllTestsInLogicTestBundle

- (void)testTestSpecifierIsAllWhenRunningAllTestsInApplicationTestBundle
{
NSDictionary *allSettings =
BuildSettingsFromOutput([NSString stringWithContentsOfFile:TEST_DATA @"OSX-Application-Test-showBuildSettings.txt"
encoding:NSUTF8StringEncoding
error:nil]);
NSDictionary *testSettings = allSettings[@"TestProject-App-OSXTests"];
NSDictionary *testSettings = @{kBuiltProductsDir : AbsolutePathFromRelative(TEST_DATA @"TestProject-App-OSX/Build/Products/Debug/"),
kFullProductName : @"TestProject-App-OSXTests.octest",
kSdkName : GetAvailableSDKsAndAliases()[@"macosx"],
kTestHost : AbsolutePathFromRelative(TEST_DATA @"TestProject-App-OSX/Build/Products/Debug/TestProject-App-OSX.app/Contents/MacOS/TestProject-App-OSX"),
};

OCUnitTestRunner *runner = TestRunnerWithTestList([OCUnitTestRunner class], testSettings, @[@"Cls1/testA", @"Cls2/testB"]);

Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -25,17 +25,17 @@
<key>DTCompiler</key>
<string>com.apple.compilers.llvm.clang.1_0</string>
<key>DTPlatformBuild</key>
<string>5A2053</string>
<string>5A3005</string>
<key>DTPlatformVersion</key>
<string>GM</string>
<key>DTSDKBuild</key>
<string>13A595</string>
<key>DTSDKName</key>
<string>macosx10.9</string>
<key>DTXcode</key>
<string>0501</string>
<string>0502</string>
<key>DTXcodeBuild</key>
<string>5A2053</string>
<string>5A3005</string>
<key>LSMinimumSystemVersion</key>
<string>10.8</string>
<key>NSHumanReadableCopyright</key>
Expand Down
Binary file not shown.
Original file line number Diff line number Diff line change
Expand Up @@ -23,16 +23,16 @@
<key>DTCompiler</key>
<string>com.apple.compilers.llvm.clang.1_0</string>
<key>DTPlatformBuild</key>
<string>5A2053</string>
<string>5A3005</string>
<key>DTPlatformVersion</key>
<string>GM</string>
<key>DTSDKBuild</key>
<string>13A595</string>
<key>DTSDKName</key>
<string>macosx10.9</string>
<key>DTXcode</key>
<string>0501</string>
<string>0502</string>
<key>DTXcodeBuild</key>
<string>5A2053</string>
<string>5A3005</string>
</dict>
</plist>
Binary file not shown.

0 comments on commit 720d152

Please sign in to comment.