Skip to content
This repository has been archived by the owner on Jan 13, 2022. It is now read-only.

Fine tunning siege benchmark options #71

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

racardoso
Copy link

Summary:

To set siege parameters for benchmark, oss-performance uses static
functions defined on PerfSettings.
It's seems more easy if we can do this via command line rather than
edit file.

This commit introduces three new command line options:

--benckmark-time
--benchmark-concurrency
--benchmark-warm-concurrency

Those functions permits to set benchmark time, benchmark concurrency
and, warmup (multi) concurrency values. Oss-performance will use default
values if you don't pass anything or pass a invalid value.

Those options doen't affect single request warmup stage.

Summary:

To set siege parameters for benchmark, oss-performance uses static
functions defined on PerfSettings.
It's seems more easy if we can do this via command line rather than
edit file.

This commit introduces three new command line options:

--benckmark-time
--benchmark-concurrency
--benchmark-warm-concurrency

Those functions permits to  set benchmark time, benchmark concurrency
and, warmup (multi) concurrency values. Oss-performance will use default
values if you don't pass anything or pass a invalid value.

Those options doen't affect single request warmup stage.
@fredemmott
Copy link
Contributor

Sorry for the delay: this should be modified so that --i-am-not-benchmarking is specified. Even if slightly inaccurate, we've had huge problems with people running with different settings without telling anyone. Anything that significantly affects performance beyond the defaults should be covered by that option.

@racardoso
Copy link
Author

Ok i will made those changes and submit.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants