Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Linking fix for Android with min SDK ver less than 24 #3794

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

vok1980
Copy link

@vok1980 vok1980 commented Oct 18, 2023

No description provided.

@facebook-github-bot
Copy link

Hi @vok1980!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

@Cyan4973
Copy link
Contributor

Cyan4973 commented Mar 3, 2024

reference for fseeko :
https://www.man7.org/linux/man-pages/man3/fseeko.3.html

@Cyan4973
Copy link
Contributor

Cyan4973 commented Mar 4, 2024

It seems it would be possible to test the availability of fseeko() directly within cmake:

include(CheckFunctionExists)
check_function_exists(fseeko HAVE_FSEEKO)

if(NOT HAVE_FSEEKO)
  add_definitions(-DHAVE_NOT_FSEEKO)
endif()

Such a variant would be more generic than just testing for specific Android versions within cmake.

@Cyan4973
Copy link
Contributor

Cyan4973 commented Mar 4, 2024

Alternatively, it seems it would be possible to detect Android version directly within the C preprocessor, using #if defined(__ANDROID_API__) && __ANDROID_API__ < 24.
Such a method would have the advantage of being independent of the build system, therefore not being restricted to active cmake participation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants