Commits on Oct 8, 2023

1. fix #3764 …

   This answer a static analysis tool,
   which complains that a buffer allocation is not free() just before exit().
   
   In general, this requirement is not necessary, because invoking exit() will make the OS reclaim all buffers from the terminated process.
   
   I could articulate this new requirement in a "not too heavy" way with the use of a new macro, `CONTROL_EXIT()`.
   But "not too heavy" is still a form of maintenance burden: whenever the code is modified, by adding, removing or changing some of these buffers, it requires some form of coordination with exit points, which is easy to let go wrong.
   Besides, I wouldn't be surprised if there were some more complex scenarios left, typically across multiple levels of functions, where a call to `exit()` is made while some other buffers, inaccessible from the function, are still allocated. Tackling such issues would require a very different approach, typically forbidding the use of `exit()`, which was meant to simplify code maintenance by reducing the nb and complexity of error paths.
   I question the need to make the code more complex to read and maintain, just to tackle a largely theoretical problem with no practical impact on target platforms.

   

   Cyan4973 committed Oct 8, 2023
   Configuration menu

   • View commit details
   • Copy full SHA for bfeb456
   • Browse repository at this point

   Copy the full SHA

   bfeb456 View commit details

   Browse the repository at this point in the history