Skip to content

Commit

Permalink
upgrade pyre version in fbcode/opensource - batch 1 (#1024)
Browse files Browse the repository at this point in the history
Summary: Pull Request resolved: facebookincubator/zstrong#1024

Differential Revision: D64977670

fbshipit-source-id: 505d9709aa088f7811e0f4d6d7ba26b07ffdbc94
  • Loading branch information
generatedunixname89002005307016 authored and facebook-github-bot committed Oct 26, 2024
1 parent fda975c commit e22de99
Show file tree
Hide file tree
Showing 3 changed files with 4 additions and 2 deletions.
2 changes: 2 additions & 0 deletions build/fbcode_builder/getdeps/expr.py
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,10 @@ def top(self):

def ident(self) -> str:
ident = self.lex.get_token()
# pyre-fixme[6]: For 2nd argument expected `str` but got `Optional[str]`.
if not re.match("[a-zA-Z]+", ident):
raise Exception("expected identifier found %s" % ident)
# pyre-fixme[7]: Expected `str` but got `Optional[str]`.
return ident

def parse_not(self) -> NotExpr:
Expand Down
1 change: 0 additions & 1 deletion build/fbcode_builder/getdeps/platform.py
Original file line number Diff line number Diff line change
Expand Up @@ -216,7 +216,6 @@ def __init__(self, ostype=None, distro=None, distrovers=None) -> None:
ostype = "darwin"
elif is_windows():
ostype = "windows"
# pyre-fixme[16]: Module `sys` has no attribute `getwindowsversion`.
distrovers = str(sys.getwindowsversion().major)
elif sys.platform.startswith("freebsd"):
ostype = "freebsd"
Expand Down
3 changes: 2 additions & 1 deletion build/fbcode_builder/getdeps/py_wheel_builder.py
Original file line number Diff line number Diff line change
Expand Up @@ -95,13 +95,14 @@
# something like the following pip3 command:
# pip3 --isolated install --no-cache-dir --no-index --system \
# --target <install_dir> <wheel_file>
# pyre-fixme[13] fields initialized in _build
class PythonWheelBuilder(BuilderBase):
"""This Builder can take Python wheel archives and install them as python libraries
that can be used by add_fb_python_library()/add_fb_python_executable() CMake rules.
"""

# pyre-fixme[13]: Attribute `dist_info_dir` is never initialized.
dist_info_dir: str
# pyre-fixme[13]: Attribute `template_format_dict` is never initialized.
template_format_dict: Dict[str, str]

def _build(self, reconfigure: bool) -> None:
Expand Down

0 comments on commit e22de99

Please sign in to comment.