fix: fix valid-shorthands object casting error on css-shorthand-expand null return #814
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
workflow: benchmarks/sizeComparison of minified (terser) and compressed (brotli) size results, measured in bytes. Smaller is better.
|
mellyeliu
commented
Dec 17, 2024
| import stylex from 'stylex'; | ||
| const styles = stylex.create({ | ||
| main: { | ||
| borderRight: '4px solid var(--fds-gray-10)' |
There was a problem hiding this comment.
still identifying repros to make the test more robust
Prakshal-Jain
approved these changes
Dec 17, 2024
There was a problem hiding this comment.
Assuming we are aligned that we should return if css shorthand expand fails, the changes LGTM.
@nmn please feel free to chime in since you have more context 🙂
|
Lint error will still be triggered, we just will not provide an autofix. Merging as SEV follow up |
mellyeliu
added a commit
that referenced
this pull request
Dec 20, 2024
aminaopio
pushed a commit
to aminaopio/stylex
that referenced
this pull request
Dec 22, 2024
aminaopio
pushed a commit
to aminaopio/stylex
that referenced
this pull request
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What changed / motivation ?
Certain complex shorthand values like
'4px solid var(--fds-gray-10)'seem to trip up the css-shorthand-expand package, which defaults to returning null. Let's handle the cases by prematurely returning and not providing an autofix in such cases.Testing
Still identifying repros to make the test more robust
Contribution Guidelines