Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: Implemented "recipe" page #791

Merged
merged 9 commits into from
Dec 22, 2024
Merged

Conversation

aminaopio
Copy link
Contributor

@aminaopio aminaopio commented Dec 2, 2024

What changed / motivation ?

Implemented a recipe page within the docs that contains a bunch of common styling patterns.

Additional Context

Screenshot 2024-12-04 at 5 28 41 PM Screenshot 2024-12-04 at 5 28 48 PM Screenshot 2024-12-04 at 5 28 57 PM

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 2, 2024
@aminaopio
Copy link
Contributor Author

@nmn Thoughts? I can definitely find more examples to add if necessary

@p0nch000
Copy link
Contributor

p0nch000 commented Dec 2, 2024

if there's something else to add to the docs, I can help with it lmk

@nmn
Copy link
Contributor

nmn commented Dec 4, 2024

Can we break up the recipes into separate pages so we can put more detail into each recipe over time?

apps/docs/docs/learn/04-styling-ui/03-recipes.mdx Outdated Show resolved Hide resolved
apps/docs/docs/learn/04-styling-ui/03-recipes.mdx Outdated Show resolved Hide resolved
apps/docs/docs/learn/04-styling-ui/03-recipes.mdx Outdated Show resolved Hide resolved
apps/docs/docs/learn/04-styling-ui/03-recipes.mdx Outdated Show resolved Hide resolved
@aminaopio
Copy link
Contributor Author

Can we break up the recipes into separate pages so we can put more detail into each recipe over time?

Gotcha, I implemented your suggestions, and added a folder for recipes with each individual page separated. Should be good to go, but let me know

Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more changes needed, but nearly there.

apps/docs/docs/learn/06-recipes/01-contexual-styles.mdx Outdated Show resolved Hide resolved
apps/docs/docs/learn/06-recipes/01-contexual-styles.mdx Outdated Show resolved Hide resolved
apps/docs/docs/learn/06-recipes/02-variants.mdx Outdated Show resolved Hide resolved
apps/docs/docs/learn/06-recipes/03-descendant styles.mdx Outdated Show resolved Hide resolved
apps/docs/docs/learn/06-recipes/01-contexual-styles.mdx Outdated Show resolved Hide resolved
@aminaopio
Copy link
Contributor Author

A few more changes needed, but nearly there.

Think it's done

Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Still a few issues. I'll fix them and merge it.

apps/docs/docs/learn/06-recipes/01-contexual-styles.mdx Outdated Show resolved Hide resolved
@aminaopio
Copy link
Contributor Author

@nmn Forgot about this one, but let me know if anything else can be done on my end!

@nmn
Copy link
Contributor

nmn commented Dec 12, 2024

@aminaopio This is good for now. I will merge it soon. (Note: I plan to do an edit pass and write some more recipes before merging this)

@nmn nmn merged commit 2d9ceaa into facebook:main Dec 22, 2024
7 of 8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants