Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove React.MixedElement from the typescript example #72

Merged
merged 1 commit into from
Dec 6, 2023
Merged

Remove React.MixedElement from the typescript example #72

merged 1 commit into from
Dec 6, 2023

Conversation

none23
Copy link
Contributor

@none23 none23 commented Dec 6, 2023

AFAIK, React.MixedElement is not a valid type in Typescript

@none23 none23 force-pushed the remove-mixed-element-from-ts-example branch from 8ec5df7 to 7654a69 Compare December 6, 2023 20:30
@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 6, 2023
nmn
nmn approved these changes Dec 6, 2023
View reviewed changes
Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch!

@nmn nmn merged commit c3b5cd6 into facebook:main Dec 6, 2023
8 checks passed
@none23 none23 deleted the remove-mixed-element-from-ts-example branch December 13, 2023 13:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nmn nmn nmn approved these changes

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@none23 @nmn @facebook-github-bot