Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ESLint] Improve handling of resolving local constants #6

Merged
merged 4 commits into from
Nov 22, 2023
Merged

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Nov 22, 2023

When using as and satisfies expressions, ESLint should now be able to resolve the static value used in the styles.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2023
Copy link

compressed-size: runtime library

Size change: 0.00 kB
Total size: 2.36 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.02 (3.53) 0.00 (0.00) 0.0% (0.0%)
./packages/stylex/lib/StyleXSheet.js 1.34 (3.41) 0.00 (0.00) 0.0% (0.0%)

Copy link

compressed-size: e2e bundles

Size change: 0.00 kB
Total size: 1119.39 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 1005.22 (9872.52) 0.00 (0.00) 0.0% (0.0%)
./apps/rollup-example/.build/stylex.css 114.18 (455.95) 0.00 (0.00) 0.0% (0.0%)

@nmn nmn merged commit 92b8767 into main Nov 22, 2023
7 checks passed
@nmn nmn deleted the improve-linting branch November 22, 2023 08:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants