Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix types for theming with tests #5

Merged
merged 1 commit into from
Nov 22, 2023
Merged

Fix types for theming with tests #5

merged 1 commit into from
Nov 22, 2023

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Nov 22, 2023

Ran into some type errors when using the Theming APIs with Typescript. After much work, I managed to get it working correctly.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Nov 22, 2023
Copy link

compressed-size: runtime library

Size change: 0.00 kB
Total size: 2.36 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.02 (3.53) 0.00 (0.00) 0.0% (0.0%)
./packages/stylex/lib/StyleXSheet.js 1.34 (3.41) 0.00 (0.00) 0.0% (0.0%)

Copy link

compressed-size: e2e bundles

Size change: 0.00 kB
Total size: 1119.39 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 1005.22 (9872.52) 0.00 (0.00) 0.0% (0.0%)
./apps/rollup-example/.build/stylex.css 114.18 (455.95) 0.00 (0.00) 0.0% (0.0%)

@nmn nmn merged commit 289cb7c into main Nov 22, 2023
7 checks passed
@nmn nmn deleted the better-theming-types branch November 22, 2023 04:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants