Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Default useRemForFontSize to false #29

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Fix: Default useRemForFontSize to false #29

merged 1 commit into from
Dec 5, 2023

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Dec 5, 2023

As this transformation can be surprising, keep it off by default.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2023
@nmn nmn requested a review from necolas December 5, 2023 20:01
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

compressed-size: runtime library

Size change: 0.00 kB
Total size: 2.36 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.02 (3.53) 0.00 (0.00) 0.0% (0.0%)
./packages/stylex/lib/StyleXSheet.js 1.34 (3.41) 0.00 (0.00) 0.0% (0.0%)

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2023

compressed-size: e2e bundles

Size change: +0.03 kB
Total size: 1119.60 kB

Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/stylex.css 114.25 (456.00) +0.03 (-0.04) 0.0% (-0.0%) 🔴
View unchanged
Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 1005.35 (9859.49) 0.00 (-0.12) 0.0% (-0.0%)

@nmn nmn merged commit 69883ed into main Dec 5, 2023
8 checks passed
@nmn nmn deleted the rem-default branch December 5, 2023 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@necolas necolas Awaiting requested review from necolas

Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nmn @facebook-github-bot