Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Allow additional -webkit- properties #28

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Chore: Allow additional -webkit- properties #28

merged 1 commit into from
Dec 5, 2023

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Dec 5, 2023

Added a few more -webkit- properties that are commonly supported and used in browsers.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 5, 2023
Copy link

github-actions bot commented Dec 5, 2023

compressed-size: runtime library

Size change: 0.00 kB
Total size: 2.36 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.02 (3.53) 0.00 (0.00) 0.0% (0.0%)
./packages/stylex/lib/StyleXSheet.js 1.34 (3.41) 0.00 (0.00) 0.0% (0.0%)

@nmn nmn requested a review from necolas December 5, 2023 20:01
Copy link

github-actions bot commented Dec 5, 2023

compressed-size: e2e bundles

Size change: 0.00 kB
Total size: 1119.56 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 1005.35 (9859.61) 0.00 (0.00) 0.0% (0.0%)
./apps/rollup-example/.build/stylex.css 114.22 (456.05) 0.00 (0.00) 0.0% (0.0%)

@nmn nmn merged commit cf47293 into main Dec 5, 2023
8 checks passed
@nmn nmn deleted the ts-improvements branch December 5, 2023 20:01
@@ -70,12 +70,10 @@ const styles = stylex.create({
},
mask1: {
maskImage: 'linear-gradient(125deg, white 30%, transparent 65%)',
// eslint-disable-next-line @stylexjs/valid-styles
WebkitMaskImage: 'linear-gradient(125deg, white 30%, transparent 65%)',
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would be nice to polyfill properties by outputting prefixed versions, rather than requiring developers to include them?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants