Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chore: Clarify stability of theming APIs #27

Merged
merged 1 commit into from
Dec 5, 2023
Merged

Chore: Clarify stability of theming APIs #27

merged 1 commit into from
Dec 5, 2023

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Dec 4, 2023

Based on feedback that the theming APIs seemed unsafe to use, I've documentation to clarify that the theming APIs themselves are stable, and only the configuration to enable should be considered unstable.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 4, 2023
Copy link

github-actions bot commented Dec 4, 2023

compressed-size: runtime library

Size change: 0.00 kB
Total size: 2.36 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.02 (3.53) 0.00 (0.00) 0.0% (0.0%)
./packages/stylex/lib/StyleXSheet.js 1.34 (3.41) 0.00 (0.00) 0.0% (0.0%)

Copy link

github-actions bot commented Dec 4, 2023

compressed-size: e2e bundles

Size change: 0.00 kB
Total size: 1119.56 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 1005.35 (9859.61) 0.00 (0.00) 0.0% (0.0%)
./apps/rollup-example/.build/stylex.css 114.22 (456.05) 0.00 (0.00) 0.0% (0.0%)

@nmn nmn merged commit bc2fc69 into main Dec 5, 2023
8 checks passed
@nmn nmn deleted the theming-docs branch December 5, 2023 00:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants