Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: cta section responsive issue #146

Merged
merged 3 commits into from
Dec 13, 2023
Merged

Conversation

mehedihsajib
Copy link
Contributor

@mehedihsajib mehedihsajib commented Dec 12, 2023

What changed / motivation ?

FIX: CTA section's responsive issue fixed

Additional Context

Issue was:

When screen size is around 370-380px the CTA section touches the edge which is not looks good (Please check the attached screenshot)

Changes I made:

  • There was several options to fix it. I just reduced the padding-x of those button when screen size is less then 390px

Before:

cta-before

After:

cta-after

Notes for Reviewers:

Hope you are going great.
Please check my changes and if you have suggestions or need any modification please let me know.

Thank you for your time and consideration!

Pre-flight checklist

@facebook-github-bot
Copy link

Hi @mehedihsajib!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

Copy link
Contributor

@nmn nmn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CTA button is also used for the button the /playground page. We should add padding around the buttons instead.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 12, 2023
@mehedihsajib
Copy link
Contributor Author

The CTA button is also used for the button the /playground page. We should add padding around the buttons instead.

Hi,
Thanks for your feedback.
The parent of those button is 'flex' without 'flex-wrap' that's why when screen gets narrower the button crossed the screen and margin/padding not get reflected.

So instead of using padding I just change the media query 360px to 385px and now it seems okay.
If you still any better suggestion please do let me know.

Thanks.

@nmn
Copy link
Contributor

nmn commented Dec 12, 2023

Please fix the prettier failure.

@mehedihsajib
Copy link
Contributor Author

Please fix the prettier failure.

Hi, the prettier failure is fixed now.

@mehedihsajib mehedihsajib requested a review from nmn December 13, 2023 13:54
@nmn nmn merged commit fd4108e into facebook:main Dec 13, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants