fix: strict report for stylex.create argument as object expression

[kotarella1110]

What changed / motivation ?

I have fixed to report when a value other than an ObjectExpression is specified as an argument for stylex.create.

Additional Context

Pre-flight checklist

• I have read the contributing guidelines
  Contribution Guidelines
• Performed a self-review of my code

[facebook-github-bot]

Hi @kotarella1110!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at [email protected]. Thanks!

[nmn]

I don't think this change can be made without a bigger refactor, but I'll let the tests run in case this is accounted for.

[nmn]

The rest of the code still depends on it being an object expression.

[nmn]

Interesting! The tests are still working.

[nmn]

I'll merge for now since the tests are still passing. The bigger refactor can wait.

[kotarella1110]

@nmn

I don't think this change can be made without a bigger refactor, but I'll let the tests run in case this is accounted for.

What do you mean?

The only fix to this PR is that the following code is executed when a value other than ObjectExpression is specified as the argument to stylex.create.

stylex/packages/eslint-plugin/src/stylex-valid-styles.js

Lines 2745 to 2755 in ca1dc8b

	const namespaces = node.arguments[0];
	// const loc: ?AST['SourceLocation'] = namespaces.loc;
	if (namespaces.type !== 'ObjectExpression') {
	return context.report(
	({
	node: namespaces,
	loc: namespaces.loc,
	message: 'Styles must be represented as JavaScript objects',
	}: Rule.ReportDescriptor),
	);
	}

Prior to this fix, the following code would not report a problem, but now it does.

stylex.create("test")
stylex.create(1)
const foo = {}
stylex.create(foo)

[nmn]

@kotarella1110 That's my misunderstanding. Thanks!