Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix : add types to fontWeight #125

Merged
merged 1 commit into from
Dec 11, 2023
Merged

fix : add types to fontWeight #125

merged 1 commit into from
Dec 11, 2023

Conversation

purohitdheeraj
Copy link
Contributor

What changed / motivation ?

This PR will adds string and number type in fontWeight types in StyleXCSSTypes.js

Linked PR/Issues

Fixes #124

Additional Context

Tested it

image

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 11, 2023
@nmn nmn merged commit 10ffbec into facebook:main Dec 11, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Typing mismatch for fontWeight property (maybe others?)
3 participants
@purohitdheeraj @nmn @facebook-github-bot