Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: CSS layer order in Next.js app #119

Merged
merged 1 commit into from
Dec 10, 2023
Merged

Fix: CSS layer order in Next.js app #119

merged 1 commit into from
Dec 10, 2023

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Dec 10, 2023

What changed / motivation ?

The nextJS example didn't have margins or paddings because the reset styles overriding all StyleX styles. (because of @CSS layers).

Fixed this by putting the reset styles in a CSS Layer themselves.

Additional Context

image

Pre-flight checklist

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 10, 2023
Copy link

compressed-size: runtime library

Size change: 0.00 kB
Total size: 2.36 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.02 (3.53) 0.00 (0.00) 0.0% (0.0%)
./packages/stylex/lib/StyleXSheet.js 1.34 (3.41) 0.00 (0.00) 0.0% (0.0%)

Copy link

compressed-size: e2e bundles

Size change: 0.00 kB
Total size: 1126.06 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 1005.35 (9859.49) 0.00 (0.00) 0.0% (0.0%)
./apps/rollup-example/.build/stylex.css 120.70 (870.91) 0.00 (0.00) 0.0% (0.0%)

@nmn nmn merged commit dbc49fb into main Dec 10, 2023
9 checks passed
@nmn nmn deleted the fix-next-css-layers branch December 10, 2023 07:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants