Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: Builds on Windows #115

Merged
merged 1 commit into from
Dec 9, 2023
Merged

Fix: Builds on Windows #115

merged 1 commit into from
Dec 9, 2023

Conversation

nmn
Copy link
Contributor

@nmn nmn commented Dec 9, 2023

Resolves #78

There are three solve issues fixed in this PR:

  1. rm -rf doesn't exist on windows. Replaced with rimraf.
  2. NODE_ENV=... doesn't exist on windows. Replaces with cross-env NODE_ENV=...
  3. Windows will use \r\n for line endings which broke gen-types script. Updated the script to find and replace all \r\n with \n first.

@facebook-github-bot facebook-github-bot added the CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. label Dec 9, 2023
Copy link

github-actions bot commented Dec 9, 2023

compressed-size: runtime library

Size change: 0.00 kB
Total size: 2.36 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./packages/stylex/lib/stylex.js 1.02 (3.53) 0.00 (0.00) 0.0% (0.0%)
./packages/stylex/lib/StyleXSheet.js 1.34 (3.41) 0.00 (0.00) 0.0% (0.0%)

Copy link

github-actions bot commented Dec 9, 2023

compressed-size: e2e bundles

Size change: 0.00 kB
Total size: 1126.06 kB

View unchanged
Filename: gzip (minify) kB size kB change % change
./apps/rollup-example/.build/bundle.js 1005.35 (9859.49) 0.00 (0.00) 0.0% (0.0%)
./apps/rollup-example/.build/stylex.css 120.70 (870.91) 0.00 (0.00) 0.0% (0.0%)

@nmn nmn merged commit 66c51e3 into main Dec 9, 2023
9 checks passed
@nmn nmn deleted the windows-fixes branch December 9, 2023 13:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Can't get the project to run locally on Windows
2 participants