Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add
esbuild
plugin #113feat: add
esbuild
plugin #113Changes from 3 commits
7d0268a
94b7407
14637f0
6fe9c5f
d3a0f5f
cd62e9f
4a287db
7811896
17011de
eb94b3c
90b06c3
083de80
891c561
bad0b30
9c1ee21
0aa6583
96324ac
52caaf3
35f164d
27dcb73
0fcd813
922f158
7a788d0
99da76c
f4ff4da
8b9fca8
e48090a
a12edd2
3e1692f
2608220
6b25103
736c1f2
9338cb8
4ff83a5
ac9caa0
a07f5bb
91f6eca
cd1f8b9
9615a5b
6fa1540
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
Large diffs are not rendered by default.
Check failure on line 12 in packages/esbuild-plugin/src/index.js
GitHub Actions / lint
Check failure on line 26 in packages/esbuild-plugin/src/index.js
GitHub Actions / lint
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tsx
loader can handlets
,tsx
andjsx
filesThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
update: turns out this wasn't entirely correct. encountered some import resolution problems when using
tsx
loader forJSX
files, even though theesbuild
documentation said that either loader is fine. for the sake of simplicity, I just match extension to loader. we can rely on extensions because of the filter guarantees.I could also create a dictionary and map extension to loader in case
esbuild
changes the loader names or we want to use different loader for a given extension. lmk what you think.