-
Notifications
You must be signed in to change notification settings - Fork 313
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf: babel-plugin exports static methods type #102
Conversation
export type StyleXTransformObj = { | ||
(): PluginObj<>, | ||
withOptions: typeof styleXTransform.withOptions, | ||
processStylexRules: typeof processStylexRules, | ||
... | ||
}; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
export type StyleXTransformObj = { | |
(): PluginObj<>, | |
withOptions: typeof styleXTransform.withOptions, | |
processStylexRules: typeof processStylexRules, | |
... | |
}; | |
export type StyleXTransformObj = $ReadOnly<{ | |
(): PluginObj<>, | |
withOptions: typeof styleXTransform.withOptions, | |
processStylexRules: typeof processStylexRules, | |
... | |
}>; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would prefer the type to be read-only if possible.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is a nice improvement. Thanks!
Make
@stylexjs/babel-plugin
types happy.The pr exports methodstyleXTransform
static methods types.