Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[MovieApp] Add key to image components inside of MovieCell. #2059

Closed
wants to merge 0 commits into from
Closed

[MovieApp] Add key to image components inside of MovieCell. #2059

wants to merge 0 commits into from

Conversation

christopherdro
Copy link
Contributor

Resolves #89

test plan: open movies app, search for various movie titles, ensure that the images match the titles

@facebook-github-bot facebook-github-bot added GH Review: review-needed CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed. labels Jul 20, 2015
@brentvatne
Copy link
Collaborator

looks good to me

@brentvatne brentvatne changed the title [MovieApp] Add key to image components inside of MovieCell. Resolve: #89 [MovieApp] Add key to image components inside of MovieCell. Jul 20, 2015
@sophiebits
Copy link
Contributor

It would probably be better to add the key to the whole cell:

Mind changing it to that?

@christopherdro
Copy link
Contributor Author

That's actually what my first attempt at resolving the issue was.

However, I was still able to reproduce the issue.

Could this be a bug with the Image component?

@sophiebits
Copy link
Contributor

That doesn't make sense to me.

@sophiebits
Copy link
Contributor

If the row's key changes, all of its descendants including the Image will be recreated.

@christopherdro
Copy link
Contributor Author

Hmm, I must've of overlooked something then.
I just tested a decent amount of times with setting the key on the whole cell.

Will cleanup and push. Thanks

@christopherdro
Copy link
Contributor Author

Sorry for the problems.
Created a new PR with the proper changes.

#2065

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CLA Signed This label is managed by the Facebook bot. Authors need to sign the CLA before a PR can be reviewed.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants