Skip to content

Commit

Permalink
Add commitHlc as an optional field to MultiWrite{Request,Reply}
Browse files Browse the repository at this point in the history
Summary:
As title, in support of read atomicity on TAO. No op, fields not currently used and is
`optional`. I also had to add it to the MSMWv2 endpoints as they go into the same `MultiWriteResult` struct (through multiple layers of abstraction) in CC.

Reviewed By: davidgoode

Differential Revision: D61860932

fbshipit-source-id: 2cb5c4efc005d405886d4ea27a31df762bdd9f65
  • Loading branch information
Matt Pugh authored and facebook-github-bot committed Dec 6, 2024
1 parent 6c2142a commit d4991b4
Showing 1 changed file with 4 additions and 1 deletion.
5 changes: 4 additions & 1 deletion mcrouter/lib/network/gen/Common.thrift
Original file line number Diff line number Diff line change
Expand Up @@ -63,7 +63,7 @@ cpp.virtual
)
struct McVersionReply {
1: carbon_result.Result result
2: binary (cpp.type = "folly::IOBuf") value
2: binary_5325 value
3: string message
4: i16 appSpecificErrorCode
}(cpp.methods = "
Expand Down Expand Up @@ -251,3 +251,6 @@ struct GoAwayRequest {
",
cpp.virtual
)

// The following were automatically generated and may benefit from renaming.
typedef binary (cpp.type = "folly::IOBuf") binary_5325

0 comments on commit d4991b4

Please sign in to comment.