Add a constexpr var to indicate whether McRefill is enabled for a Router

Summary: as title Reviewed By: disylh Differential Revision: D61503306 fbshipit-source-id: edd74112c23088fa512afd36493cb438a23a2f83
facebook · Aug 23, 2024 · 7f5c691 · 7f5c691
1 parent 17d4965
commit 7f5c691
Show file tree

Hide file tree

Showing 8 changed files with 12 additions and 0 deletions.
diff --git a/mcrouter/lib/carbon/example/gen/HelloGoodbyeRouterInfo.h b/mcrouter/lib/carbon/example/gen/HelloGoodbyeRouterInfo.h
@@ -76,6 +76,7 @@ struct HelloGoodbyeRouterInfo {
   static constexpr const char* name = "HelloGoodbye";
   static constexpr const bool bucketization = false;
   static constexpr const bool useRequestAclChecker = false;
+  static constexpr const bool hasMcRefillRoute = false;
 
   template <class Route>
   using RouteHandle = HelloGoodbyeRouteHandle<Route>;

diff --git a/mcrouter/lib/carbon/test/gen/ARouterInfo.h b/mcrouter/lib/carbon/test/gen/ARouterInfo.h
@@ -79,6 +79,7 @@ struct ARouterInfo {
   static constexpr const char* name = "A";
   static constexpr const bool bucketization = false;
   static constexpr const bool useRequestAclChecker = false;
+  static constexpr const bool hasMcRefillRoute = false;
 
   template <class Route>
   using RouteHandle = ARouteHandle<Route>;

diff --git a/mcrouter/lib/carbon/test/gen/BRouterInfo.h b/mcrouter/lib/carbon/test/gen/BRouterInfo.h
@@ -79,6 +79,7 @@ struct BRouterInfo {
   static constexpr const char* name = "B";
   static constexpr const bool bucketization = false;
   static constexpr const bool useRequestAclChecker = false;
+  static constexpr const bool hasMcRefillRoute = false;
 
   template <class Route>
   using RouteHandle = BRouteHandle<Route>;

diff --git a/mcrouter/lib/carbon/test/gen/CarbonTestRouterInfo.h b/mcrouter/lib/carbon/test/gen/CarbonTestRouterInfo.h
@@ -79,6 +79,7 @@ struct CarbonTestRouterInfo {
   static constexpr const char* name = "CarbonTest";
   static constexpr const bool bucketization = false;
   static constexpr const bool useRequestAclChecker = false;
+  static constexpr const bool hasMcRefillRoute = false;
 
   template <class Route>
   using RouteHandle = CarbonTestRouteHandle<Route>;

diff --git a/mcrouter/lib/carbon/test/gen/CarbonThriftTestRouterInfo.h b/mcrouter/lib/carbon/test/gen/CarbonThriftTestRouterInfo.h
@@ -82,6 +82,7 @@ struct CarbonThriftTestRouterInfo {
   static constexpr const char* name = "CarbonThriftTest";
   static constexpr const bool bucketization = false;
   static constexpr const bool useRequestAclChecker = false;
+  static constexpr const bool hasMcRefillRoute = false;
 
   template <class Route>
   using RouteHandle = CarbonThriftTestRouteHandle<Route>;

diff --git a/mcrouter/lib/network/Memcache.idl b/mcrouter/lib/network/Memcache.idl
@@ -472,6 +472,9 @@ reply McGatsReply with 1: MemcacheReplyCommon {
 
 service {
   additional_requests: [];
+  additional_route_handles: [
+      McRefillRoute @ "mcrouter/routes/McRefillRoute.h"
+  ];
   on_reply_logger: facebook::memcache::mcrouter::AdditionalProxyRequestLogger;
   enable_shutdown: false;
   stats: {

diff --git a/mcrouter/lib/network/gen/MemcacheRouterInfo.cpp b/mcrouter/lib/network/gen/MemcacheRouterInfo.cpp
@@ -47,6 +47,8 @@
 
 #include <mcrouter/routes/McExtraRouteHandleProvider.h>
 
+#include "mcrouter/routes/McRefillRoute.h"
+
 using namespace facebook::memcache;
 using namespace facebook::memcache::mcrouter;
 
@@ -189,6 +191,7 @@ MemcacheRouterInfo::buildRouteMap() {
       {"OperationSelectorRoute",
        &makeOperationSelectorRoute<MemcacheRouterInfo>},
       {"RandomRoute", &makeRandomRoute<MemcacheRouterInfo>},
+      {"McRefillRoute", &makeMcRefillRoute<MemcacheRouterInfo>},
   };
   return map;
 }

diff --git a/mcrouter/lib/network/gen/MemcacheRouterInfo.h b/mcrouter/lib/network/gen/MemcacheRouterInfo.h
@@ -139,6 +139,7 @@ struct MemcacheRouterInfo {
   static constexpr const char* name = "Memcache";
   static constexpr const bool bucketization = true;
   static constexpr const bool useRequestAclChecker = true;
+  static constexpr const bool hasMcRefillRoute = true;
 
   template <class Route>
   using RouteHandle = MemcacheRouteHandle<Route>;