Add comment about binary protocol fields

facebook · Aug 27, 2018 · 626d816 · 626d816
1 parent f7b6323
commit 626d816
Showing 1 changed file with 3 additions and 0 deletions.
diff --git a/mcrouter/lib/network/McBinaryParser.cpp b/mcrouter/lib/network/McBinaryParser.cpp
@@ -276,6 +276,8 @@ void McServerBinaryParser::consumeArithLike() {
   auto& message          = currentMessage_.get<Request>();
   message.key()          = std::move(currentKey_);
   message.delta()        = ntohl(extras->delta);
+  // These fields are for binary protocol only, we cannot forward them to
+  // upstream servers because we use the ASCII protocol for upstreams
   // message.initialValue() = ntohl(extras->initialValue);
   // message.exptime() = ntohl(extras->exptime);
   message.quiet()        = quiet;
@@ -298,6 +300,7 @@ template <bool quiet>
 void McServerBinaryParser::consumeFlush() {
   // auto extras       = reinterpret_cast<const FlushExtras_t*>(currentExtras_.data());
   auto& message     = currentMessage_.get<McFlushAllRequest>();
+  // Binary protocol only fields
   // message.exptime() = ntohl(extras->exptime);
   message.quiet()   = quiet;
   callback_->onRequest(std::move(message));