Skip to content

Commit

Permalink
add iPhone 16 to our hard coded stuff
Browse files Browse the repository at this point in the history 
Summary: This is such a bad way to scale, but it is what we have.  Updating parts hard coded parts.

Reviewed By: jarman

Differential Revision: D62473369

fbshipit-source-id: acc48d14661283b0eb29995097c05b7417ec0b0c
  • Loading branch information
@facebook-github-bot
Nolan O'Brien authored and facebook-github-bot committed Sep 11, 2024
1 parent 5c5e3bd commit 1b8aa4e
Show file tree
Hide file tree
Showing 2 changed files with 12 additions and 0 deletions.
4 changes: 4 additions & 0 deletions FBControlCore/Configuration/FBiOSTargetConfiguration.h
View file
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,10 @@ extern FBDeviceModel const FBDeviceModeliPhone15;
extern FBDeviceModel const FBDeviceModeliPhone15Plus;
extern FBDeviceModel const FBDeviceModeliPhone15Pro;
extern FBDeviceModel const FBDeviceModeliPhone15ProMax;
extern FBDeviceModel const FBDeviceModeliPhone16;
extern FBDeviceModel const FBDeviceModeliPhone16Plus;
extern FBDeviceModel const FBDeviceModeliPhone16Pro;
extern FBDeviceModel const FBDeviceModeliPhone16ProMax;
extern FBDeviceModel const FBDeviceModeliPodTouch_7thGeneration;
extern FBDeviceModel const FBDeviceModeliPad2;
extern FBDeviceModel const FBDeviceModeliPad_6thGeneration;
Expand Down
8 changes: 8 additions & 0 deletions FBControlCore/Configuration/FBiOSTargetConfiguration.m
View file
Original file line number Diff line number Diff line change
Expand Up @@ -46,6 +46,10 @@
FBDeviceModel const FBDeviceModeliPhone15Plus = @"iPhone 15 Plus";
FBDeviceModel const FBDeviceModeliPhone15Pro = @"iPhone 15 Pro";
FBDeviceModel const FBDeviceModeliPhone15ProMax = @"iPhone 15 Pro Max";
FBDeviceModel const FBDeviceModeliPhone16 = @"iPhone 16";
FBDeviceModel const FBDeviceModeliPhone16Plus = @"iPhone 16 Plus";
FBDeviceModel const FBDeviceModeliPhone16Pro = @"iPhone 16 Pro";
FBDeviceModel const FBDeviceModeliPhone16ProMax = @"iPhone 16 Pro Max";
FBDeviceModel const FBDeviceModeliPodTouch_7thGeneration = @"iPod touch (7th generation)";
FBDeviceModel const FBDeviceModeliPad2 = @"iPad 2";
FBDeviceModel const FBDeviceModeliPadRetina = @"iPad Retina";
Expand Down Expand Up @@ -482,6 +486,10 @@ @implementation FBiOSTargetConfiguration
[FBDeviceType iPhoneWithModel:FBDeviceModeliPhone15Plus productTypes:@[@"iPhone15,5"] deviceArchitecture:FBArchitectureArm64],
[FBDeviceType iPhoneWithModel:FBDeviceModeliPhone15Pro productTypes:@[@"iPhone16,1"] deviceArchitecture:FBArchitectureArm64],
[FBDeviceType iPhoneWithModel:FBDeviceModeliPhone15ProMax productTypes:@[@"iPhone16,2"] deviceArchitecture:FBArchitectureArm64],
[FBDeviceType iPhoneWithModel:FBDeviceModeliPhone16 productTypes:@[@"iPhone17,3"] deviceArchitecture:FBArchitectureArm64],
[FBDeviceType iPhoneWithModel:FBDeviceModeliPhone16Plus productTypes:@[@"iPhone17,4"] deviceArchitecture:FBArchitectureArm64],
[FBDeviceType iPhoneWithModel:FBDeviceModeliPhone16Pro productTypes:@[@"iPhone17,1"] deviceArchitecture:FBArchitectureArm64],
[FBDeviceType iPhoneWithModel:FBDeviceModeliPhone16ProMax productTypes:@[@"iPhone17,2"] deviceArchitecture:FBArchitectureArm64],
[FBDeviceType iPhoneWithModel:FBDeviceModeliPodTouch_7thGeneration productTypes:@[@"iPod9,1"] deviceArchitecture:FBArchitectureArm64],
[FBDeviceType iPadWithModel:FBDeviceModeliPad2 productTypes:@[@"iPad2,1", @"iPad2,2", @"iPad2,3", @"iPad2,4"] deviceArchitecture:FBArchitectureArmv7],
[FBDeviceType iPadWithModel:FBDeviceModeliPadRetina productTypes:@[@"iPad3,1", @"iPad3,2", @"iPad3,3", @"iPad3,4", @"iPad3,5", @"iPad3,6"] deviceArchitecture:FBArchitectureArmv7],
Expand Down

0 comments on commit 1b8aa4e

Please sign in to comment.