Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support no_unchecked_indexed_access=true #9239

Closed
wants to merge 4 commits into from

Conversation

SamChou19815
Copy link
Contributor

@SamChou19815 SamChou19815 commented Dec 11, 2024

Changelog: [feature] Flow now supports no_unchecked_indexed_access=true, which is equivalent to noUncheckedIndexedAccess from TS. It will add | void to every indexed access with general string key on dictionary objects or number key on arrays.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@SamChou19815 SamChou19815 changed the title Introduce flag that is equivalent to noUncheckedIndexedAccess in TS Support no_unchecked_indexed_access=true Dec 11, 2024
@SamChou19815 SamChou19815 marked this pull request as draft December 11, 2024 21:06
@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@SamChou19815 SamChou19815 marked this pull request as ready for review December 12, 2024 04:57
@facebook-github-bot
Copy link
Contributor

@SamChou19815 merged this pull request in 1cd0a55.

@SamChou19815 SamChou19815 deleted the strict-indexed-access-flag branch December 12, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants