[WIP] Type Iterator.from #9231
Closed
[WIP] Type Iterator.from #9231
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
hurrymaplelad
commented
Nov 22, 2024
| from<+Yield,+Return,-Next>(source: $Iterable<Yield,Return,Next>): $Iterator<Yield,Return,Next>; | ||
| } | ||
|
|
||
| declare var Iterator: IteratorConstructor; |
There was a problem hiding this comment.
This is how TypeScript declares Iterator.from, but Flow does not permit the re-declaration (error: name-already-bound). Try Flow.
Would be nice if they worked the same way. Nothing in #8989 about this yet.
|
Declaring
|
hurrymaplelad
force-pushed
the
iterator-from
branch
from
2eb7a49 to
387de8b
Compare
|
@facebook-github-bot has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Closed
|
Found a working path as part of #9232. Merged into that PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For #9230, which has context on
Iterator.from().I haven't gotten this working yet. Notes in comments.